Users/mkuriche/rocprofiler sdk fmt build fix memory header #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-actions
bot
added
the
github actions
ammarwa
approved these changes
Jan 9, 2026
jbonnell-amd
approved these changes
Jan 9, 2026
- remedy use of fmt::join without include <fmt/ranges.h>
MythreyaK
force-pushed
the
users/mkuriche/rocprofiler-sdk-fmt-build-fix-memory-header
branch
from
baf8a4c to
c006722
Compare
…fix-memory-header
jbonnell-amd
deleted the
users/mkuriche/rocprofiler-sdk-fmt-build-fix-memory-header
branch
systems-assistant bot
pushed a commit
to ROCm/rocprofiler-sdk
that referenced
this pull request
Jan 12, 2026
(#2537) * [rocprofiler-sdk] Fix fmt::join build errors - remedy use of fmt::join without include <fmt/ranges.h> * include memory header * Disable FMT build for SDK CI * Add -DROCPROFILER_BUILD_FMT=OFF to sanitizer steps * Add temporary workaround for rccl.h issue * Add ROCPROFILER_INTERNAL_RCCL_API_TRACE to SDK CI builds * disable clang-tidy for vendored includes [rocm-systems] ROCm/rocm-systems#2537 (commit 36d9d33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist